add Google secrets #859
Merged
add Google secrets #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AstrakhantsevaAA
force-pushed
the
dlt_secret_toml
branch
from
70bd6c9
to
5948e3f
Compare
rudolfix
approved these changes
Dec 28, 2023
| # Slack hook for chess in production example | ||
| RUNTIME__SLACK_INCOMING_HOOK: ${{ secrets.RUNTIME__SLACK_INCOMING_HOOK }} | ||
| # Mongodb url for nested data example | ||
| MONGODB_PIPELINE__SOURCES__CONNECTION_URL: ${{ secrets.MONGODB_PIPELINE__SOURCES__CONNECTION_URL }} | ||
|
|
||
| # Qdrant credentials | ||
| DESTINATION__QDRANT__CREDENTIALS__LOCATION: ${{ secrets.DESTINATION__QDRANT__CREDENTIALS__LOCATION }} |
There was a problem hiding this comment.
maybe you could add qdrant to destination secret in google secrets and remove that? optional.
Pipboyguy
pushed a commit
that referenced
this pull request
Jan 1, 2024
* add Google secrets * test_config_providers doesn't return anything * return test utils * config.toml not from google secrets * set working dir * remove return typing * remove unused line * add google client to deps * delete sources ENVs * return back performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable Google Secrets for doc tests (code-snippets).
Related Issues
Additional Context