corrected data type #863
Merged
corrected data type #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
deleted the
862-from_db_type-method-in-mssqltypemapper-class-references-non-existing-data-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the data type used in the
from_db_typemethod in classMsSqlTypeMapperwhich referred to anumericdata type that isn't used formssql.Related Issues
from_db_typemethod inMsSqlTypeMapperclass references non-existing data type #862Additional Context
I also removed the
weiexclusion formssqlintest_get_storage_table_with_all_types. With the corrected data type, this test passes without the exclusion.