Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(filesystem): include Google Drive into filesystem tutorial #962

Merged
merged 4 commits into from Feb 26, 2024

Conversation

IlyaFaer
Copy link
Collaborator

Towards dlt-hub/verified-sources#308
Follows the changes made in the PR #932

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit c8217e4
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65cb03a5213e9c000947f319
😎 Deploy Preview https://deploy-preview-962--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IlyaFaer IlyaFaer marked this pull request as ready for review February 12, 2024 12:48
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good, but I didn't understand the question about schema

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • could you rename "google analytics API" to "Cloud Storage API" and "Google Drive API"
  • also, we should give some info if user has no google cloud account, just regular google account and gdrive. In this case we can use OAuth.

if you don't want to waste your time on documentation, tell me, I'll reassign the task to someone else

@IlyaFaer
Copy link
Collaborator Author

IlyaFaer commented Feb 13, 2024

also, we should give some info if user has no google cloud account, just regular google account and gdrive. In this case we can use OAuth.

You mean if the user doesn't have a service account?
The feature of user auth (not a service account) for Google is not yet supported. Marcin created a core issue for it (it's gonna be one basic mechanism for all Google features in dlt):
#943

@rudolfix
Copy link
Collaborator

@IlyaFaer google auth is supported. I was running tests on it. what is not supported is the python-data credential cache and browser authentication. but if you do that and get refresh token with proper scopes you can configure the thing to work.

we are giving instructions on how to do it for many of our verified sources. some kind of guide on how to use filesystem with your personal gdrive and oauth would be cool! @AstrakhantsevaAA maybe we should give that task to @dat-a-man or someone else?

otherwise I'm good with this PR (I trust you guys :)

@IlyaFaer
Copy link
Collaborator Author

So, what? I guess let's merge this PR and create a task for this second part with tutorial, so you could assign it to whoever you want.

@AstrakhantsevaAA AstrakhantsevaAA merged commit e035e38 into devel Feb 26, 2024
44 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the gdrive_docs branch February 26, 2024 12:37
@AstrakhantsevaAA
Copy link
Contributor

reassigned to Aman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants