Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(airflow): implement parallel-isolated mode #979

Merged
merged 6 commits into from Feb 26, 2024
Merged

Conversation

IlyaFaer
Copy link
Collaborator

Towards: #931

Implements parallel-isolated decomposition mode.
Made in about the same way as the parallel mode, but the first source component is executed in parallel with others.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 6b8f98c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65dce0981e89a000079d4c98

@IlyaFaer IlyaFaer marked this pull request as ready for review February 19, 2024 10:56
@IlyaFaer
Copy link
Collaborator Author

@rudolfix, I'm not 100% sure I understood what you mean by before execution pipeline will be forked under new name so state will be isolated. You mean that it'll be cloned with the drop() method here?

task_pipeline = pipeline.drop()

It'll clone the pipeline, so seems to me it's what you mean by forking. Or maybe you mean that ForkPipe()?

@rudolfix
Copy link
Collaborator

@rudolfix, I'm not 100% sure I understood what you mean by before execution pipeline will be forked under new name so state will be isolated. You mean that it'll be cloned with the drop() method here?

task_pipeline = pipeline.drop()

It'll clone the pipeline, so seems to me it's what you mean by forking. Or maybe you mean that ForkPipe()?

you are right! ticket was not clear. please take a look at updated requirements. also I added a requirement to add users if state is written in parallel mode

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! but spec was not clear so please see my comment...

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have one issue (probably tickets were not clear). tests are really top!

dlt/helpers/airflow_helper.py Show resolved Hide resolved
dlt/helpers/airflow_helper.py Outdated Show resolved Hide resolved
dlt/helpers/airflow_helper.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyaFaer I changed the parallel mode to not run in separate pipeline names. I think the ticket was not clear. otherwise good. test that attach to all partial pipelines is cool

@rudolfix rudolfix merged commit 14b0a66 into devel Feb 26, 2024
48 of 55 checks passed
@rudolfix rudolfix deleted the paralle_isolated branch February 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants