New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotation processing and rebuilding, mark dataclass as complex #980
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement of the tests!
- did you really needed to update poetry.lock? library deps didn't change so maybe you could revert this change and push again (let's see what fails, if anything)
- you have consistent error in all common test on is Union so I think it is a problem with a test
@rudolfix I reverted mypy and typing-extensions updates and then defined UUID4 like pydantic does and moved back the tests into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for tests and I hope @codingcyclist it will fix your issues. it took us some time as we didn't want to solve the problem brutally without understanding a root cause.
This PR
complex
type,4.9.0
and mypy to1.8.0