Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation processing and rebuilding, mark dataclass as complex #980

Merged
merged 24 commits into from Feb 21, 2024

Conversation

sultaniman
Copy link
Collaborator

@sultaniman sultaniman commented Feb 19, 2024

This PR

  1. fixes multiples issues related to Pydantic schema inference and type detection logic,
  2. marks dataclasses as complex type,
  3. Upgrades typing extensions to 4.9.0 and mypy to 1.8.0
  • Updating typing-extensions (4.6.3 -> 4.9.0)
  • Downgrading asttokens (2.4.1 -> 2.3.0)
  • Downgrading fsspec (2023.12.2 -> 2023.6.0)
  • Updating mypy (1.6.1 -> 1.8.0)

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 6b73db9
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65d5d504a605eb0008838614

@sultaniman sultaniman changed the title Issue 951 Fix annotation processing and rebuilding, mark dataclass as complex Feb 20, 2024
@sultaniman sultaniman marked this pull request as ready for review February 20, 2024 10:46
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement of the tests!

  • did you really needed to update poetry.lock? library deps didn't change so maybe you could revert this change and push again (let's see what fails, if anything)
  • you have consistent error in all common test on is Union so I think it is a problem with a test

@sultaniman
Copy link
Collaborator Author

@rudolfix I reverted mypy and typing-extensions updates and then defined UUID4 like pydantic does and moved back the tests into test_typing.py

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for tests and I hope @codingcyclist it will fix your issues. it took us some time as we didn't want to solve the problem brutally without understanding a root cause.

@rudolfix rudolfix merged commit 9a59c17 into devel Feb 21, 2024
60 of 61 checks passed
@rudolfix rudolfix deleted the issue-951 branch February 21, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants