Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] add include_custom_props to hubspot source #404

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

cmpadden
Copy link
Contributor

Tell us what you do here

  • Adds top-level include_custom_props parameter to hubspot source

Related Issues

Was experiencing the same issue as #330.

<class 'dlt.extract.exceptions.ResourceExtractionError'>
In processing pipe companies: extraction of resource companies in generator companies caused an exception: Your request to Hubspot is too long to process. Maximum allowed query length is 2000 symbols, while your list of properties `about_us,address,address2,admin__c,annualrevenue,arr__c,auto_renew__c,channel_partner__c,cicd_provider__c,city,closedate,closedate_timestamp_earliest_value_a2a17e6e,cloud_credits__c,cloud_provider__c,`... is 2854 symbols long. Use the `props` argument of the resource to set t

This introduced a top-level parameter to disable the custom props on all resources.

@rudolfix rudolfix added the ci from fork Allows to run tests from PR coming from fork label Mar 20, 2024
Copy link
Contributor

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tests are passing

@rudolfix rudolfix merged commit e060ed5 into dlt-hub:master Mar 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci from fork Allows to run tests from PR coming from fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants