Change default Subscribed tab to Involved #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `Subscribed` tabs in the default config to `Involved` tabs and changes the filter from hard-coded repos (such as `cli/cli`) to `involves:@me`. This addresses behavior that has surprised some folks such as in dlvhdr#74 and dlvhdr#129. Ideally, we could fetch issues/PRs that the user has subscribed to, but it looks like there's not an obvious way to do that. In its absence, the `involves` filter might be a reasonable default that is less surprising to people.
|
Yeah that's cool, thanks @ceedubs |
dlvhdr
approved these changes
Aug 29, 2022
|
I ended up also adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the
Subscribedtabs in the default config toInvolvedtabs and changes the filter from hard-coded repos (such as
cli/cli) toinvolves:@me.This addresses behavior that has surprised some folks such as in #74 and #129.
Ideally, we could fetch issues/PRs that the user has subscribed to, but
it looks like there's not an obvious way to do that. In its absence, the
involvesfilter might be a reasonable default that is less surprisingto people.
How did you test this change?
I changed my local config to match this and ran
gh dashto observe the results.Admittedly I did not set up a
goenvironment to test these changes.Images/Videos