Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate draft PRs from open PRs #158

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

molawson
Copy link
Contributor

@molawson molawson commented Aug 18, 2022

Summary

Tweak a couple of key bits of the UI to differentiate an open draft PR from an open non-draft PR in the table view and the sidebar.

I decided to scope this change to only affect open draft PRs. A closed PR could also be a draft, but that seems much less useful and important once it's been closed.

Fixes #157

How did you test this change?

I ran it locally with my config which currently contains a draft PR.

Images/Videos

Before
gh-dash draft PR before

After
gh-dash draft PR after

Copy link
Owner

@dlvhdr dlvhdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution 💖

@dlvhdr dlvhdr merged commit 4a71bed into dlvhdr:main Aug 18, 2022
@molawson molawson deleted the draft-pr branch August 18, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate Draft PRs
2 participants