-
Notifications
You must be signed in to change notification settings - Fork 82
Give LOGO decoders the ability to track state across calls. #53
Conversation
|
||
trait Inferencer[S] { | ||
def initialState: S | ||
def reduceStates(state1: S, state2: S): S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S is suffstats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does it relate to W?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh state. i don't quite understand its role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arbitrary state that the implementers of inferencers may want to carry around. The abstraction is like mapreduce: you return some stuff, and also say how to combine that stuff, then you get the combined stuff in various callbacks. Allows inferencers to have internal state without worrying about threadsafety. Sounds like I need some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
On Thu, May 26, 2016 at 8:26 PM, adampauls notifications@github.com wrote:
In src/main/scala/epic/logo/Inferencer.scala
#53 (comment):@@ -0,0 +1,7 @@
+package epic.logo
+
+trait Inferencer[S] {
- def initialState: S
- def reduceStates(state1: S, state2: S): S
Arbitrary state that the implementers of inferencers may want to carry
around. The abstraction is like mapreduce: you return some stuff, and also
say how to combine that stuff, then you get the combined stuff in various
callbacks. Allows inferencers to have internal state without worrying about
threadsafety. Sounds like I need some comments.—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/dlwh/epic/pull/53/files/bdf0547a0919d604cf236bdc542181e413f7e9a8#r64852990,
or mute the thread
https://github.com/notifications/unsubscribe/AAAloTkt927OW3um6hasHga5VroxisuLks5qFmR7gaJpZM4In_F1
.
RFAL |
* This class stores the dual variables and constraints for each training exampe. | ||
* It is mutable for efficiency purposes. | ||
*/ | ||
case class DualVariableHolder[T, W](var x: T, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.