New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Input event triggered when value prop is changed #89
Comments
Hi, which version do you use? This was originally fixed in 1.15.1. |
version is updated... |
I believe I was using the most recent version |
@Soviut: I can not reproduce this: If I change the state directly with Vue DevTools there's only a |
@dm4t2 I've the same problem. On my example you can open the devtools and you will see that the message is logged before actually a change happened. |
@alipishevar I noticed in your example that the distraction free formatting gets lost each time the component's context changes. Is that your issue? @DevelGitH So everything's fine or is there still an issue? |
@dm4t2 only for the version 1.15.1 |
Yes of course |
I was no using the distraction-free mode in mine, it was updating commas as you typed. @dm4t2 I'll have to try again and see about using the difference between |
- directive: dispatch input events on all value changes to sync value binding - component: only emit input/change events on number value changes
The event handling issues should be fixed with Release 1.17.0 🎉 |
@dm4t2 Did you removed the events completely? The events on the component aren't working anymore. See my new issue |
Unfortunately there was a bug not covered/detectable by the unit tests. Change events should be triggered correctly again with Release 1.17.1. |
I'm using the vue-currency-input in an app that uses Vuex. As such, I'm not using the v-model, I'm using a bound
:value
field to get Vuex state into the component and@input
event to get updated values back out.I have several currency fields and noticed they're all triggering their
@input
events when their:value
changes, rather than just when someone inputs something in the field. This causes a cascade of fields to change.I would expect that the
@input
only triggers when a human causes the input, the way regular form fields work.I'll gladly try my hand at a PR if you agree.
The text was updated successfully, but these errors were encountered: