-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to leave network card without ip address #502
Comments
this is problematic code from
getting to
from what I have learn about go in last days :
should not reach |
@MalloZup I would like to contribute by fixing this issue. But unfortunately I stuck on point which I mention above. I would appreciate much if you would help me to finish it even if it is easier for you just silently fix it :) |
@asmorodskyi currently i still don't get your issue and i'm trying to reproduce. Remember that it is an opensource and community project here, and also in day by day business i am busy with other stuff. As i say before, i don't know how to reproduce and dunno what is your problem, so i'm taking the time to see where is the problem , and see if i can reproduce it 🌻 Once i got the picture we can help fixing the problem. |
@MalloZup didn't plan to push you anyhow take your time and get to the issue whenever it will suit your priorities list I have no problems with that. Meanwhile I will try to proceed on my own. In case you have any certain question I am ready to answer. |
@asmorodskyi no worry, it is ok! thank you for feedback and infos. 💘 |
@asmorodskyi ok i see the problem. What i would try if i were you:
Looking at the codebase shortly, i think we could remove now that IF. But i would give a try, to see if we have other failures |
@asmorodskyi As @MalloZup mentioned, I think the key would be to replace the https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L663-L674 block by a |
@MalloZup I deleted more then you suggesting https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L655-L665 because go complains about
@inercia sorry but I am not experienced enough to understand what you meant under "..." or go supports exactly such string ? Nevertheless not sure how it could help if we failing before lines which you suggesting to change https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/domain.go#L664 |
Sorry, I was suggesting to do something like: if wait {
// the resource specifies a hostname but not an IP, so we must wait until we
// have a valid lease and then read the IP we have been assigned, so we can
// do the mapping
log.Printf("[DEBUG] Do not have an IP for '%s' yet: will wait until DHCP provides one...", hostname)
partialNetIfaces[strings.ToUpper(mac)] = &pendingMapping{
mac: strings.ToUpper(mac),
hostname: hostname,
network: network,
}
} |
to investigate qcow error i did the following :
So for me it looks like something which requires investigation too no related to current issue. I mean it shouldn't the case that problems in one domain cause errors in another, right ? |
@asmorodskyi your snippet of terraform without network Interface is ok that you don't have any error, if you remove the The comment from @inercia to me make sense. see (#502 (comment)) With that modified codebase, if i were you, i would build the provider and then retry this note that the networkInterface is present on 🎅 🤶 3️⃣ 🎁 🎅 |
@MalloZup I just tried code suggested by @inercia with initial
|
after spending more time on reading a code I found that we need to clarify issue description :
when I add |
fixed and works on latest master thx |
@MalloZup so just to clarify for myself - my assumption was wrong and to create network with mode=nat you don't need any IP ? Also can you please advise me what release model libvirt-provider has ? I mean when I will see released version which will contain this fix ? Want to test it |
you can build from source the master branch. fix pr #556. for the released version we need to do other things before releasing a new version. |
Full example
Details
Given network:
And network interface:
It is not possible to leave the IP address unconfigured, which is a common case for QA teams.
The text was updated successfully, but these errors were encountered: