Fix libvirt ovmf firmware integration test on non-Ubuntu #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On SUSE systems, these paths are different. In order to reuse the code that looks for the right files, we make the template and no-template case sub-tests of the main test containing the lookup code. Also, if the files are not there, skip the test.
MalloZup
reviewed
Nov 10, 2017
| subtestAccLibvirtDomain_FirmwareNoTemplate(t, nvram_path, firmware) | ||
| }) | ||
| t.Run("With Template", func(t *testing.T) { | ||
| subtestAccLibvirtDomain_FirmwareTemplate(t, nvram_path, firmware, template) |
There was a problem hiding this comment.
nitpick can we avoid to use nvram_path and use camelCase ```nvramPath` (will make golint happy)
dmacvicar
force-pushed
the
fix_firmware_test_suse
branch
from
d87e9e7
to
0171fe8
Compare
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
dmacvicar
force-pushed
the
fix_firmware_test_suse
branch
from
0171fe8
to
d770be4
Compare
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
dmacvicar
force-pushed
the
fix_firmware_test_suse
branch
from
d770be4
to
59e2398
Compare
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
Repository owner
deleted a comment from
coveralls
Nov 10, 2017
monstermunchkin
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SUSE systems, these paths are different.
In order to reuse the code that looks for the right files, we make the template and no-template case sub-tests of the main test containing the lookup code.
Also, if the files are not there, skip the test.