Retry HTTP downloads for 5xx errors #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmacvicar
force-pushed
the
dmacvicar_download_retry
branch
from
24cd20e
to
4c7554c
Compare
MalloZup
reviewed
Nov 15, 2018
dmacvicar
force-pushed
the
dmacvicar_download_retry
branch
from
4c7554c
to
6e6440f
Compare
|
Incorporated latest feedback from @MalloZup. Waiting for tests. |
MalloZup
approved these changes
Nov 15, 2018
dmacvicar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what is suggested on #455
Most of the work was to do the proper testcase.
I also discovered a bug: we where not erroring at all for non-200 codes. We ignored this part of the documentation:
So Import did not error, and the error we spit to the user was probably some garbage when trying to read an empty response. This is now fixed in 5fa3124
TODO