Switch to use Go modules #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move as much stuff as possible from scripts to the main Makefile
Travis puts the source inside GOPATH, so GO111MODULE=auto ends with modules disabled.
MalloZup
reviewed
Feb 17, 2019
|
I think it is ready for review now. |
MalloZup
approved these changes
Feb 21, 2019
|
Tested inside GOPATH with GO111MODULES=off |
|
Packages are also building correctly. They build with classical GOPATH + vendor/ by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we have been using glide to manage dependencies.
I don't think Go modules need an introduction, but here is a good place to start.
This PR moves the dependency handling to use Go 1.11 modules.
Worth mentioning, other providers like AWS already moved. It should not affect the end contributor, as we also vendor dependencies (
go mod vendor), but it will give the ability to develop outside ofGOPATH, which is very convenient.The PR also refactors the Makefile/travis chain in order to build using modules with the vendor directory inside travis. I also moved some of the lint/fmt checks from the travis scripts into the main Makefile after realizing the mess was so big having useless scripts inside travis/ that we were NOT actually running unit tests inside Travis 馃槧. We do now.
There are still a bunch of other scripts there to cleanup, so in a later PR I may end removing the travis directory completely.