fix(domain): update domain running state when refreshed

[Naewis]

System Information

Linux distribution

Debian GNU/Linux 10 (buster)

Terraform version

Terraform v0.12.12

Provider and libvirt versions

Compiled against library: libvirt 5.0.0
Using library: libvirt 5.0.0
Running hypervisor: QEMU 3.1.0
Running against daemon: 5.0.0

---

Checklist

Your issue is it a bug or something that does not work as expected.

Description of Issue

I'm currently using libvirt locally on my PC. Whenever I shutdown my computer, all the domains are stopped (which is correct, I don't wan't some tests domain to restart whenever I restart the host). Until then, all's good.

But when I want to restart my stack after a reboot, terraform says that there is nothing to do. As the domains are in stopped state, I expected terraform to put them online again (in order to get immutable infrastructure). I noticed that the running property doesn't get updated when terraform tries a refresh.

What did I do

I used the method domainIsRunning in order to get the domain state, and updated the schema running property. Tests were all good, but there seems to be a bug which is not related to this PR.

---

Additional information:

Apparmor is disabled.

First PR, and first GO code : sorry if I did something wrong in the way.
Please tell me in order to improve.

On a side note, there is also something wrong with the network state refresh.
When I ran the tests, i got this :

Error: Error creating libvirt domain: virError(Code=55, Domain=19, Message='Requested operation is not valid: network 'default' is not active')

$ sudo virsh net-list --all
 Name          State      Autostart   Persistent
--------------------------------------------------
 default       inactive   no          yes

[MalloZup]

@Naewis thx for PR. I will have look soonish 👍

[MalloZup]

related on same context : #622 (however 2 diff issues)

[Naewis]

As far as I've tested, this patch fixes the issue #622, but the fix is not really elegant, I must agreed, as I know nothing of Golang (automatic test code seems too much at my current level)

Sadly, I have a little time to fix this issue anymore (as learning Go is not in my todo list for now, maybe later), but if I were fluent in Go, I would fix some issues by not re-reading domain global state when we create the resource (l. 569 : err = resourceLibvirtDomainRead(d, meta) ) but instead use a separate variable and re-inject explicitly only needed properties into our domain variable, because I don't know which property is actually erased implicitly vs not voluntarily erased (would also fix the state matter with more style)

[Naewis]

Just to be sure, are you waiting for me to do something on this request ?

[MalloZup]

thx @Naewis for pr and sorry for delay 🏓