Add support for decription field #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin TORGiren Fabrykowski <torgiren@gmail.com>
MalloZup
reviewed
Jan 28, 2020
|
@torgiren thx for PR. 2 things:
Thx for PR! |
Signed-off-by: Marcin TORGiren Fabrykowski <torgiren@gmail.com>
MalloZup
reviewed
Jan 29, 2020
|
thx a part minor fixes looks good |
This reverts commit a1d0834.
Signed-off-by: Marcin TORGiren Fabrykowski <torgiren@gmail.com>
Signed-off-by: Marcin TORGiren Fabrykowski <torgiren@gmail.com>
MalloZup
reviewed
Feb 10, 2020
MalloZup
requested changes
Feb 10, 2020
|
@torgiren last nitpick and I will merge. Thank you a lot for your efforts sofar 🚀 |
Signed-off-by: Marcin TORGiren Fabrykowski <torgiren@gmail.com>
MalloZup
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting description field in domains