Adjust generated dhcp to match libvirt limitation of max 65535 addresses #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johscheuer thx for PR. CI is failing on this PR. We will need to have look |
johscheuer
force-pushed
the
fix-dhcp-range
branch
from
7624886
to
2b0f909
Compare
|
I believe that the failing CI is not really related to the changes, since the failing tests are located in --- FAIL: TestRemoteImageDetermineType (0.00s)
volume_image_test.go:85: listen tcp :23032: bind: cannot assign requested address
=== RUN TestRemoteImageDownloadRetry
2020/07/05 15:31:56 [DEBUG]: url resp status code 503 Service Unavailable (retry #0)
2020/07/05 15:31:58 [DEBUG]: url resp status code 503 Service Unavailable (retry #1)
2020/07/05 15:32:00 [DEBUG]: url resp status code 200 OK (retry #2)
2020/07/05 15:32:00 [DEBUG]: url resp status code 503 Service Unavailable (retry #0)
2020/07/05 15:32:02 [DEBUG]: url resp status code 404 Not Found (retry #1)
--- PASS: TestRemoteImageDownloadRetry (6.01s)
volume_image_test.go:119: Server serving retry 0
volume_image_test.go:119: Server serving retry 1
volume_image_test.go:123: Server: success (after 2 errors)
volume_image_test.go:119: Server serving retry 0
volume_image_test.go:119: Server serving retry 1
=== RUN TestRemoteImageDownload
--- FAIL: TestRemoteImageDownload (0.00s)
volume_image_test.go:170: listen tcp :55130: bind: cannot assign requested address
FAIL |
johscheuer
commented
Jul 5, 2020
| @@ -96,7 +117,7 @@ func (fws *fileWebServer) Start() error { | |||
|
|
|||
| handler := http.NewServeMux() | |||
| handler.Handle("/", http.FileServer(http.Dir(dir))) | |||
| fws.server = &http.Server{Addr: fmt.Sprintf(":%d", fws.Port), Handler: handler} | |||
| fws.server = &http.Server{Addr: fmt.Sprintf("127.0.0.1:%d", fws.Port), Handler: handler} | |||
There was a problem hiding this comment.
I assume that somehow this bug was related travis-ci/travis-ci#8711? Are there any downsides to hardcode 127.0.0.1 (except that IPv6 doesn't work 😞)
|
Friendly ping @MalloZup |
|
@johscheuer ok thx I will add it on my backlog. sorry for delay |
MalloZup
approved these changes
Aug 4, 2020
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with IPv6 and DHCP mentioned in #752 and ensures that only 2^16 addresses are used for the DHCP range (which is somehow a limitation of libvirt).