Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey out any games that have an 'uninstalled' status #35

Closed
wants to merge 2 commits into from

Conversation

jthoward64
Copy link

Big changes aside from obious UI stuff is the movement of where the status for the shown game is and the addition of a cached check for installed vs unistalled.

@dmadisetti
Copy link
Owner

I think this is a nice change. Thank you.

I will try it out this afternoon. Code looks good, my one comment is I don't think that the cache should be an App attribute, but I get that might be tricky with the borrow checker + loop

@jthoward64
Copy link
Author

I think this is a nice change. Thank you.

I will try it out this afternoon. Code looks good, my one comment is I don't think that the cache should be an App attribute, but I get that might be tricky with the borrow checker + loop

Yeah, if you can think of a better place to put it I'd be glad to move it and update the PR, but I couldn't figure a good way

@dmadisetti
Copy link
Owner

Still at work, but thought about this some more. Can't we store status in the game object?

pub struct Game {

Then no need for cache

@jthoward64
Copy link
Author

Still at work, but thought about this some more. Can't we store status in the game object?

pub struct Game {

Then no need for cache

Maybe, I was just trying to keep the scope of the changes small, but I'll give that a shot

@jthoward64
Copy link
Author

Alright, list color will now be determined after the games are loaded in, this COULD cause issues, but I think it should work. The way I wrote it should also make it easy to add other install status colors (i.e. needs update) and probably more.

@jthoward64
Copy link
Author

Still at work, but thought about this some more. Can't we store status in the game object?

pub struct Game {

Then no need for cache

Anything else I should take a look at here?

@dmadisetti dmadisetti mentioned this pull request Jul 3, 2022
Merged
dmadisetti added a commit that referenced this pull request Jul 3, 2022
Issues: #8, #11, #17, #28, #32, #34
Prs: #35, #29

* Fix dev env and update deps

* I liked your changes, merging them in (#36)

Laar3 changes

* Lars cleanup

* cleaned up interface

* Allow for game filtering

* Add time delay as psuedo-debounce for #32

* Favourites + Install highlights + another debounce

* Added proton lookup (#17, #29)

* Add mutex to trace game status

* Updated tui version
@dmadisetti
Copy link
Owner

Closed by 0.2.0 ? Let me know what you think

@dmadisetti dmadisetti closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants