Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hide games #34

Closed
Spagett1 opened this issue Jun 7, 2022 · 6 comments · Fixed by #37
Closed

[Feature Request] Hide games #34

Spagett1 opened this issue Jun 7, 2022 · 6 comments · Fixed by #37

Comments

@Spagett1
Copy link

Spagett1 commented Jun 7, 2022

Inside of steam-tui it shows up games which i dont own,
image
This is the gameslist on steam-tui ^^
and this is my normal steam library vv
image
i've made sure that the games arn't hidden or anything, i realise that you've sorta left this project alone so i understand if you don't put in the time to fix it but just thought id let you know.

@dmadisetti
Copy link
Owner

Yeahhh! Those are actually free games. I noticed the same thing, but you can actually play them. There's a flag that marks them as "free". But I thought it was almost more of a feature than a bug

@Spagett1
Copy link
Author

Spagett1 commented Jun 7, 2022

Lol, it would be really cool if there where a way to hide games, i might take a look at the source code and see if i can add a feature like that (ive been learning rust recently but not sure how hard it would be since ive never used rust-tui before)

@dmadisetti
Copy link
Owner

Yeah, you wouldn't have to change the tui code. Youd just need to mark the game as "Default" or something when parsing the response from steam cmd:

game_type: match common.get("driverversion") {

You can do a eprintln on map to see if the identifying "free" information.

Then to make the game visible, we'd change the definition of is_valid:

self.game_type == GameType::Game

This goes somewhat closely with changes needed for #11

@dmadisetti
Copy link
Owner

@Laar3 related: #35

I like your keybind idea and storing ids in the config.

@Spagett1
Copy link
Author

Spagett1 commented Jun 8, 2022

Yeah, you wouldn't have to change the tui code. Youd just need to mark the game as "Default" or something when parsing the response from steam cmd:

game_type: match common.get("driverversion") {

You can do a eprintln on map to see if the identifying "free" information.

Then to make the game visible, we'd change the definition of is_valid:

self.game_type == GameType::Game

This goes somewhat closely with changes needed for #11

Oh cool, i've managed to remove it from the left list via filtering it out of the games_list variable in the tui code but that had wasn't removing it from the right view pane (they where desyncing so youd have one game "selected" but not really, i'm not sure what variable/vector i would have to filter it out of for it to not appear in the right list.

@Spagett1
Copy link
Author

Spagett1 commented Jun 8, 2022

As for pull #35 if it where me doing it yeah id probably have an installed thing in the config file and store the gameid's of installed ones in there however caching does work too.

@dmadisetti dmadisetti changed the title Games which i dont own are showing up in steam-tui. [Feature Request] Hide games Jul 3, 2022
@dmadisetti dmadisetti linked a pull request Jul 3, 2022 that will close this issue
Merged
dmadisetti added a commit that referenced this issue Jul 3, 2022
Issues: #8, #11, #17, #28, #32, #34
Prs: #35, #29

* Fix dev env and update deps

* I liked your changes, merging them in (#36)

Laar3 changes

* Lars cleanup

* cleaned up interface

* Allow for game filtering

* Add time delay as psuedo-debounce for #32

* Favourites + Install highlights + another debounce

* Added proton lookup (#17, #29)

* Add mutex to trace game status

* Updated tui version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants