Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: remove flake-utils dep & reorganize #64

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Sep 3, 2023

All downstream users were needing to pull in flake-utils to just call a for loop which isn’t a good UX. Inlined that loop.

Also moved steam-tui into the packages.steam-tui. Also allowlisted the nonfree-software rather than allowing it all thru.

nix build worked as well as nix develop.

# build
rustfmt
rustc
cargo
clippy
rustup

# deps
pkg-config
openssl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed since inputsFrom = builtins.attrValues self.packages.${system};

@toastal
Copy link
Contributor Author

toastal commented Sep 4, 2023

Motivator: the nixpkgs version is woefully out of date & the latest release here (I believe) missed some fix needed for Nix last time I read the logs. I was going to pull this flake in as an overlay, but then I’d need to add flake-utils which adds more bloat to my flake.lock for that for loop. Organization things are tiny, but I tend to see devShells at the bottom and packages like steam-tui @ packages.steam-tui & aliasing that as default rather than having steam-tui as a top-level output.

@dmadisetti dmadisetti self-requested a review September 4, 2023 12:54
@dmadisetti dmadisetti merged commit 409afb0 into dmadisetti:main Sep 4, 2023
1 check passed
@dmadisetti
Copy link
Owner

Thank you, LGTM

@toastal toastal deleted the nix branch September 5, 2023 06:52
dmadisetti added a commit that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants