Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No buffer #8

Merged
merged 6 commits into from
Apr 8, 2017
Merged

No buffer #8

merged 6 commits into from
Apr 8, 2017

Conversation

dmadison
Copy link
Owner

@dmadison dmadison commented Apr 8, 2017

Removed the 256-byte software buffer. The buffer wasn't providing any benefits since data is immediately fetched and moved to the CRGB array, and the code is slimmer without the overhead.

The buffer was only being used to store the header information before
processing, otherwise data was retrieved immediately. Buffer and support
variables were causing more problems than anything else.
Prior to this change, code would wait for an additional byte before
latching.
@dmadison dmadison merged commit f3d1942 into master Apr 8, 2017
@dmadison dmadison deleted the no-buffer branch April 8, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant