Fix Disconnect Bug #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to separate behavior for initial connect vs successive update.
Now handles the onConnect and onDisconnect functions only if the state changes.
Rather than updating the 'connected' variable from update, just read the update result directly. If 'connected' needs to be modified, it can be done in the disconnect function.
Makes things easier to read and think about: "If connected, disconnect". Keeping the "onConnect" function the same since it doesn't actually connect to the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small bug in the auto-connect logic where if a controller disconnects in the controller detect pin stage (
isConnected()) rather than the update stage, the LED is not cleared and the HID keypresses are not released.I rewrote the class to use
onConnectanddisconnectmethods. This should handle both potential disconnect cases.