printDebug function nitpicks #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the SAMD21 core this was creating compiler warnings that the worst-case string, with 5-digit uint16_t values, would not fit in the buffer. Increasing these buffer sizes slightly to account for that edge case, although it "should" never occur if the extension controllers are behaving as expected.
Being a little more cautious about these buffers and avoiding overruns, at the expense of a tiny bit of flash memory.
Style nitpick, no functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to the
printDebugfunctions:constqualified, both to indicate intent and maybe help with optimization.sprintfcalls have been replaced withsnprintfto head off any potential buffer overruns.uint16_tcontrol values take up all five potential decimal characters of the type (10,000+). This should never happen during normal operation because it's dependent on the data returned by the controller, but the Arduino SAMD core was complaining that the buffer could overrun.Unrelated, but I also changed the capitalization on two
Mapconstants for theuDrawTabletfor style consistency. No functional change.