Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 191 by not registering event listener manually #194

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

dmaicher
Copy link
Owner

@dmaicher dmaicher commented Jan 18, 2022

Fixes #191

@dmaicher dmaicher force-pushed the fix-issue-191 branch 2 times, most recently from 82b2a97 to cc2bd97 Compare January 18, 2022 15:14
@dmaicher dmaicher marked this pull request as ready for review January 18, 2022 15:54
@dmaicher dmaicher merged commit 1f964d4 into master Jan 18, 2022
@dmaicher dmaicher deleted the fix-issue-191 branch January 18, 2022 15:55
@bobvandevijver
Copy link

@dmaicher It looks like this change broke our unit tests with the following message: "There is no active transaction".

This normally has to do with the DDL statement causing an implicit commit on certain database platforms (of which the behaviour changed with PHP8), but that does not explain why the patch upgrade from 6.7.2 to 6.7.3 would start causing this...

Do you have any clue on why this might happen?

@dmaicher
Copy link
Owner Author

@bobvandevijver hm not really. I had some similar issues when upgrading to PHP8 though.

Are you able to provide a minimal reproducer?

@bobvandevijver
Copy link

Ok, I found the cause: Sentry. When I disable that bundle, the error is no longer triggered. It also wraps the connection, so the combination of both bundles does not play that nice...

I've now only enabled the Sentry bundle for the prod env, instead of only setting the DSN for the prod env. That solves it for me, but you might use this case as there are probably other use cases out there where the connection is wrapped.

@dmaicher
Copy link
Owner Author

@bobvandevijver can you open a new issue please? I will try to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection created twice if listeners depend on repositories
2 participants