feat: upgrade to Jakarta XML Binding 3 and Java 8 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetric
commented
Oct 31, 2021
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit</groupId> | ||
| <artifactId>junit-bom</artifactId> | ||
| <version>5.8.1</version> |
There was a problem hiding this comment.
upgraded to JUnit 5, XmlUnit 2 and AssertJ. The added benefits of AssertJ are much better assertion messages, especially more detailed file content comparisons
thetric
commented
Oct 31, 2021
| @Test | ||
| @Disabled("This test works reliably on Java7 but produces different results from run to run on Java8.") |
There was a problem hiding this comment.
Disabled this test because it is not deterministic due to the mentioned behavior
|
The CI job isn't running. I guess that's because you are still using travis-ci.org which has sunset in June 2021, see https://blog.travis-ci.com/2021-05-07-orgshutdown. You will have to sign in to travis-ci.com. The disadvantage over the old service is that it is necessary to provide a payment method - even for their free tier. |
this file is not generated anymore
|
Was handled in issue #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Closes #65, #67, #64, #63