Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks - can't unregister combo #34

Closed
g00fy- opened this issue Mar 20, 2014 · 3 comments
Closed

Memory leaks - can't unregister combo #34

g00fy- opened this issue Mar 20, 2014 · 3 comments
Labels

Comments

@g00fy-
Copy link

g00fy- commented Mar 20, 2014

if register_combo https://github.com/dmauro/Keypress/blob/development/keypress.js#L645 creates new cobo object and pushes that object to the registered combo list, than obviously unregister_combo ( which checking combo equality by reference https://github.com/dmauro/Keypress/blob/development/keypress.js#L672) won't work.

@dmauro
Copy link
Owner

dmauro commented Apr 9, 2014

Thanks for catching this. This is a big bug I introduced in 2.0. Will get a fix out as soon as I have a few minutes to spend with Keypress.

@dmauro dmauro added the bug label May 4, 2014
@dmauro
Copy link
Owner

dmauro commented May 4, 2014

The fix is in the develop branch (and the docs have been updated in the gh-pages-dev branch) and I should be pushing that through to master tomorrow. The way you should be doing this is passing the object you get from the register_combo or the array from register_many method calls back into the unregister_combo and unregister_many methods (in previous versions you would pass in the same dictionary or array you passed in to the register methods).

@dmauro dmauro closed this as completed May 4, 2014
@huzgo1
Copy link

huzgo1 commented Jun 4, 2014

Hi, I've clone today with bower and I'm still have problems on unregister_combo when the parameter keys_or_combo is a string.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants