Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tag for 1.0.8 #20

Closed
afc163 opened this issue Oct 14, 2013 · 10 comments
Closed

No tag for 1.0.8 #20

afc163 opened this issue Oct 14, 2013 · 10 comments

Comments

@afc163
Copy link

afc163 commented Oct 14, 2013

git tag 1.0.8

That would be helpful, thx!

@ConnorKrammer
Copy link

I would like to second this. Then we could use it from Bower without having to run off of the master repository (where breaking changes may occur).

@dmauro
Copy link
Owner

dmauro commented Oct 14, 2013

Oh, great idea. Done and thank you.

@dmauro dmauro closed this as completed Oct 14, 2013
@ConnorKrammer
Copy link

Running bower install Keypress#1.0.8 is still giving me the error bower ENORESTARGET No tag found that was able to satisfy 1.0.8. So Bower is still searching the git repository for an actual tag. I'm not sure why bower.json isn't being looked at -- my best guess is that running git tag 1.0.8 is the easiest way to resolve this.

Oh, and a sidenote. Found this in the Bower spec document:

main [string|array of strings]

The primary acting files necessary to use your package. While Bower does not directly use these files, they are listed with the commands bower list --json and bower list --paths, so they can be used by build tools. Do not include minified files. Files should not be versioned (Bad: package.1.1.0.js; Good: package.js).

(emphasis added)

Don't know if you care about that, but thought you'd like to know.

@dmauro
Copy link
Owner

dmauro commented Oct 14, 2013

Good to know about the main tag. I didn't look closely enough at that I guess.

I did do git tag, not sure why it's not taking. Could just take some time for Bower to play catch up?
edit: I just tried bower install Keypress#1.0.8 and it went off without a hitch.

@cbebry
Copy link

cbebry commented Oct 14, 2013

I noticed that there are no tags in the GitHub list of tags for this repository. Is it possible that the tags have not been pushed up?

git push --tags

@dmauro
Copy link
Owner

dmauro commented Oct 14, 2013

Yeah, that was it. Thanks.

@ConnorKrammer
Copy link

Didn't notice that you'd just replied, and was trying it again myself.

My response: "WTF? This was broken 30 seconds ago!"

Great that it worked out.

@dmauro
Copy link
Owner

dmauro commented Oct 14, 2013

Well the weird thing is the install worked for me BEFORE I did git push --tags. :?

@ConnorKrammer
Copy link

Eh, I guess we'll never know. It's just one of those things.

@abhikmitra
Copy link

This problem suddenly appearing now. Anybody getting it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants