Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for concatenating colormaps #2

Closed
wants to merge 1 commit into from

Conversation

mandli
Copy link

@mandli mandli commented Mar 23, 2014

The class LinearSegmentedColormap also gains the functions __add__ and
__radd__ as a shortcut to the function.

The class LinearSegmentedColormap also gains the functions __add__ and
__radd__ as a shortcut to the function.
@mandli
Copy link
Author

mandli commented Aug 12, 2015

@dmcdougall What is the status of this PR? Should we assume that we need to maintain direct support for this ability or depend on matplotlib to do this?

@mandli
Copy link
Author

mandli commented Nov 28, 2015

FWIW, I had to rework this into a more complex function that returned a normalization object as well.

@mandli
Copy link
Author

mandli commented Feb 22, 2016

Merged similar functionality elsewhere.

@mandli mandli closed this Feb 22, 2016
@mandli mandli reopened this Feb 22, 2016
@mandli
Copy link
Author

mandli commented Feb 22, 2016

Ug, sorry, different repos.

This approach to merging colormaps has issues related to the normalization object associated with colormaps. There is a fix but is not quite as nice as simply adding colormaps together. See the add_colormaps function in clawpack for an example.

@dmcdougall
Copy link
Owner

dmcdougall commented Mar 3, 2017

I think this is specialised enough that a clawpack function is sufficient. Maybe we should ping the matplotlib community to gauge whether or not this functionality would be useful in other domains.

@mandli
Copy link
Author

mandli commented Mar 3, 2017

Sounds good.

@dmcdougall dmcdougall closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants