Fix tests #8
Merged
Fix tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Should there be a test that ensures once the APIVersion is changed, the string is updated? |
|
Probably, doesn't seem to be wide coverage on the endpoint code. However I would wait until after the factor is merged before spending time increasing coverage. |
This would require a much larger integration test which actually pings the endpoint. since it does fix the currently borked test cases, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the unit tests, assuming the behavior change is accurate. Changing to use the REGISTRY endpoint to v2 breaks the integration tests since the latest version of the registry is not deployed.