Fixes omnipotence for obligations (Closes stffn#90)

lib/declarative_authorization/authorization.rb

@@ -233,6 +233,8 @@ def obligations (privilege, options = {})
 
       permit!(privilege, :skip_attribute_test => true, :user => user, :context => options[:context])
 
+      return [] if roles.is_a?(Array) and not (roles & omnipotent_roles).empty?
+
       attr_validator = AttributeValidator.new(self, user, nil, privilege, options[:context])
       matching_auth_rules(roles, privileges, options[:context]).collect do |rule|
         rule.obligations(attr_validator)

test/authorization_test.rb

@@ -34,7 +34,7 @@ def test_permit_context_people
       :user => MockUser.new(:test_role))
   end
 
-  def test_permit_elevated_people
+  def test_permit_with_has_omnipotence
     reader = Authorization::Reader::DSLReader.new
     reader.parse %{
       authorization do
@@ -121,6 +121,26 @@ def test_obligations_with_conditions
           :user => MockUser.new(:test_role, :attr => 1))
   end
 
+  def test_obligations_with_omnipotence
+    reader = Authorization::Reader::DSLReader.new
+    reader.parse %{
+      authorization do
+        role :admin do
+          has_omnipotence
+        end
+        role :test_role do
+          has_permission_on :permissions, :to => :test do
+            if_attribute :attr => is { user.attr }
+          end
+        end
+      end
+    }
+    engine = Authorization::Engine.new(reader)
+    assert_equal [],
+      engine.obligations(:test, :context => :permissions,
+          :user => MockUser.new(:test_role, :admin, :attr => 1))
+  end
+
   def test_obligations_with_anded_conditions
     reader = Authorization::Reader::DSLReader.new
     reader.parse %{