Fixes Webpack 5 always picking node implementation because of package.json exports field
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagich
changed the title
exports fieldexports field
|
Thanks for the fix! It will be included in the next release. |
dmester
added a commit
that referenced
this pull request
Dec 12, 2020
dmester
added a commit
that referenced
this pull request
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like Webpack 5 now uses/respects the
exportsfield inpackage.json(see https://webpack.js.org/guides/package-exports/). This leads to problems when importing jdenticon in a browser build, because atm. only the node implementations are present.Additionally, AFAIK there seems to be no way to resolve (using resolve.alias f.ex.) a file that is not listed in the
exportsso no workaround is possible on the consuming side. From the webpack documentation:This pull request adds exports for browser implementations (only module-based) next to the node ones. The default is unchanged.