Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Chinese(Simplified) translation #558

Merged
merged 1 commit into from Dec 12, 2017
Merged

Added Chinese(Simplified) translation #558

merged 1 commit into from Dec 12, 2017

Conversation

vellxn
Copy link
Contributor

@vellxn vellxn commented Dec 7, 2017

No description provided.

@dmfs dmfs requested a review from lemonboston December 7, 2017 20:49
@dmfs
Copy link
Owner

dmfs commented Dec 7, 2017

@lemonboston please review.

dmfs
dmfs approved these changes Dec 12, 2017
View reviewed changes
Copy link
Owner

@dmfs dmfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any problems aside from the fact that the plural of "tasks" in the list view is not translated. Considering that this looks pretty much complete otherwise I'm happy to merge it nevertheless.

@dmfs
Copy link
Owner

dmfs commented Dec 12, 2017

@lemonboston how about you?

lemonboston
lemonboston approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@lemonboston lemonboston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I don't see a problem either.

@dmfs dmfs merged commit a6c5e6a into dmfs:master Dec 12, 2017
@dmfs
Copy link
Owner

dmfs commented Dec 12, 2017

@vellxn can you also provide translations for these plurals?

opentasks/opentasks/src/main/res/values/strings.xml

Lines 28 to 31 in a6c5e6a

<plurals name="number_of_tasks">
<item quantity="one">%d task</item>
<item quantity="other">%d tasks</item>
</plurals>

@vellxn vellxn mentioned this pull request Dec 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonboston lemonboston lemonboston approved these changes

@dmfs dmfs dmfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vellxn @dmfs @lemonboston