Update ContentPal to latets GitHub version, implements #763 #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to just updating the ContentPal version this also replaces usages of deprecated jems classes.
christianlupus
added a commit
to christianlupus/opentasks
that referenced
this pull request
Feb 15, 2019
Added trigger reason due to restart Revert "Added trigger reason due to restart" This reverts commit 44cd45f. Partially restore 5f4e901, fixes dmfs#711 (dmfs#712) Commit 5f4e901 contains a couple of changes which break the UI in that some elements don't respond to clicks anymore. In particular the `focusable="true"` attribute seems to cause these issues. For now we simply revert the addition of these attributes. In another story we should address the issue and fix the layout. Update SDK target level to 26. Implements dmfs#703 (dmfs#719) This also updates the support library version to 26.1.0. Due to changes in Android 8 we had to limit some background service and broadcast functionality. There are no limitations to the user experience though, but some planned features may require a different solution now (mostly because implicit broadcasts no longer work). Add signing config, implements dmfs#720 (dmfs#721) Adds an optional signing config, which is ignored if no keystore property is present. Add plugin to publish app, dmfs#718 (dmfs#722) This adds a plugin which allows for publishing the app autimatically to Google Play. Fix wrong ID being used. Fixes dmfs#723 (dmfs#724) In an earlier commit we changed how the lists are loaded. Instead of loading them from the tasks table we now load them from the instances table. This was meant to prepare support for recurring tasks. Unfortunately we missed on line where we were still using the `_id` column to get the task id (when we should actually use the `task_id` column now). This didn't cause any problem as long as the task id and the instance id where in sync (hence it wasn't an issue while testing). However, under certain circumstances this assumption is no longer true and caused an illegal Task URI to be loaded when clicking a task. The list now uses the `task_id` column to create the task URI to show. Add opentasks 1.1.14 to releases. Auto-Determine release channel, implements dmfs#725 (dmfs#726) Update the publish configuration to derive the publishing track form the version number. Add OpenTasks 1.1.15 to releases Request account visibility, implements dmfs#728 (dmfs#736) This commit adds a workaround for sync apps which don't grant account visibility to OpenTasks. If a task list is inserted which belongs to an account which we can't see, the app asks for permission to see the account. The `GET_ACCOUNTS` permission is no longer used on Android 8+ and the request for that permission will no longer be shown when the app starts. Fix track selection, fixes dmfs#747 (dmfs#748) The regular expression for the internal track didn't cover a revision descirption like `1.1.16-dirty` which is a release commit with changes. The proposed fix makes the part between the version number and `-dirty` optional. Reduce size of ProviderChangedBroadcast, fixes dmfs#744 (dmfs#749) This commit removes the changelog we've sent with the ProviderChanged Broadcast. It's never really been used so far but may blow the IPC buffer size limit. We need to find a better way to communicate changes efficiently to plugins once we support them. It's not a pressing concern though. fix recursive updateNotification calls (dmfs#751) * fix recursive updateNotification calls * replace compile with implementation Improve FTS performance, fixes dmfs#750 (dmfs#752) The previous implementation tried to use the CONFLICT_IGNORE policy when inserting new ngrams and was falling back to a query in case it failed to find the id of the exiting ngram. This was very slow because it meant an expensive query for every ngram to insert. The new solution goes over the existing ngrams and only inserts the ones which don't exist in the database. Similarily the ngram relations table is not cleared for the particular task, instead the existing ngrams are loaded and only new relations are inserted and obsolete relations are removed. Detect state saved before FM commit, fixes dmfs#756 (dmfs#760) Under certain conditions the task details fragment was about to be replaced after the fragment manager already saved its state. This caused a crash. This change checks whether the state has already been saved before committing the transaction. Always create DetailView, fixes dmfs#755 (dmfs#761) Instead of creating the details view lazily when the task is loaded, we create it in `onCreateView` so it always exist. Hopefully this fixes dmfs#755, but since the actual reason is still unclear we can't be sure. In any case the details view needs a refactoring which reduces mutable state and makes it more robust. Add some simple profiling for provider operations. supports dmfs#738 (dmfs#762) In order to evaluate the provider performance and its impact on the UX this commit adds some simple profiling statments which measure the execution time of certain operations and write them to logcat. Hopefully this helps a but to detect slow operations and bottlenecks. Update ContentPal to latest GitHub version, implements dmfs#763 (dmfs#764) In addition to just updating the ContentPal version this also replaces usages of deprecated jems classes. Early version of a Notification concept. dmfs#716 Update notification concept. * Reorder sections * distinguish between notification triggers and sources Removed typos Added title to notification relevant fields Reason is if a sync process updates the name of a task, a notification might already be showing. In this case the notification text should be updated according to the new title. The same holds true for all shown information in the notification. As the exact graphical representation of the notification is not fixed, this is thus not 100% fixed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to just updating the ContentPal version this also replaces usages of deprecated jems classes.