Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filetype of upload #2

Closed
ghost opened this issue Mar 16, 2016 · 7 comments
Closed

Filetype of upload #2

ghost opened this issue Mar 16, 2016 · 7 comments

Comments

@ghost
Copy link

ghost commented Mar 16, 2016

I find that git-s3-push works well except that my html, css and js files are given the filetype binary/octet-stream. This means that I have to instruct AWS to change the filetype so that my website can be served properly :-(

@dmfutcher
Copy link
Owner

I have committed a fix for this. It now uses the magicmime library to automatically detect the content-type of the file when it's uploaded. You can grab the fix now from master, or it will be in the next release (coming soon), along with some other new features.

@ghost
Copy link
Author

ghost commented Aug 6, 2016

Thanks, but I cannot build the update. Any tips would be welcome. NB I am a Go novice

$ go get

github.com/rakyll/magicmime

../github.com/rakyll/magicmime/magicmime.go:28:11: fatal error: 'magic.h' file not found
#include <magic.h>
^
1 error generated.

On 5 Aug 2016, at 18:52, David Futcher notifications@github.com wrote:

I have committed a fix for this. It now uses the magicmime library to automatically detect the content-type of the file when it's uploaded. You can grab the fix now from master, or it will be in the next release (coming soon), along with some other new features.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #2 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AD8oh38BP_NLu059_Q6Y-lIkR9ZyJ5vGks5qc3h0gaJpZM4HxuiN.

@dmfutcher
Copy link
Owner

magicmime depends on libmagic. It's in the file package on Arch, on Debian based systems you'll need
libmagic-dev and libmagic1. I will update the README with this info.

@ghost
Copy link
Author

ghost commented Aug 6, 2016

Thanks, the build now works for me on OSX. I used home-brew:

$ brew install libmagic

On 6 Aug 2016, at 09:38, David Futcher notifications@github.com wrote:

magicmime depends on libmagic. It's in the file package on Arch, on Debian based systems you'll need
libmagic-dev and libmagic1. I will update the README with this info.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #2 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AD8oh51ZG92RoZmeo4OpofY4x6M5eJKvks5qdEfrgaJpZM4HxuiN.

@dmfutcher
Copy link
Owner

This is fixed in 0.2.0 release. Enjoy!

@ghost
Copy link
Author

ghost commented Aug 10, 2016

Thank you. It’s working beautifully for me.

On 6 Aug 2016, at 17:54, David Futcher notifications@github.com wrote:

This is fixed in 0.2.0 release. Enjoy!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #2 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AD8oh5_1Cy99PftqkaHkgWpgwiopCeqwks5qdLxXgaJpZM4HxuiN.

@Willjfield
Copy link

This is great. Is there an 0.2.0 release for osx? I'm having this issue but don't see a way to upgrade. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants