ninka-wrappers: support running on existing directories #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the directories will not be touched; rather they will be copied to fresh temporary directories before processing, exactly as it happens for tarballs and the like
|
It would be nice to refactor code across to the 2 wrappers (excel and sqlite), to avoid the code duplication that forced me to do the same changes to the two files. But I didn't want to conflate refactoring with the support for running on directories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the directories will not be touched; rather they will be copied to fresh
temporary directories before processing, exactly as it happens for tarballs and
the like