pet linter

address.go

@@ -65,9 +65,8 @@ func (a fakeAddress) PostcodeByState(state string) string {
 		_, ok := pbs[state]
 		if ok {
 			return NumerifyAndLetterify(Fetch("address.postcode_by_state." + state))
-		} else {
-			panic(fmt.Sprintf("invalid state: %v", state))
 		}
+		panic(fmt.Sprintf("invalid state: %v", state))
 	case []string:
 		return NumerifyAndLetterify(Fetch("address.postcode_by_state"))
 	default:

code.go

@@ -26,7 +26,7 @@ func (c fakeCode) Isbn10() string {
 		panic(err)
 	}
 
-	var sum int = 0
+	var sum int
 	for i, v := range val {
 		n, err := strconv.Atoi(string(v))
 		if err != nil {
@@ -38,9 +38,8 @@ func (c fakeCode) Isbn10() string {
 
 	if rem == 10 {
 		return fmt.Sprintf("%s-X", val)
-	} else {
-		return fmt.Sprintf("%s-%d", val, rem)
 	}
+	return fmt.Sprintf("%s-%d", val, rem)
 }
 
 func ean13() (ean string, checkDigit string) {
@@ -49,7 +48,7 @@ func ean13() (ean string, checkDigit string) {
 		panic(err)
 	}
 
-	var sum int = 0
+	var sum int
 	for i, d := range ean {
 		n, err := strconv.Atoi(string(d))
 		if err != nil {
@@ -82,7 +81,7 @@ func (c fakeCode) Ean8() string {
 		panic(err)
 	}
 
-	var sum int = 0
+	var sum int
 	for i, d := range ean {
 		n, err := strconv.Atoi(string(d))
 		if err != nil {
@@ -107,7 +106,7 @@ func (c fakeCode) Rut() string {
 		panic(err)
 	}
 
-	var sum int = 0
+	var sum int
 	for i, d := range rut {
 		n, err := strconv.Atoi(string(d))
 		if err != nil {
@@ -138,7 +137,7 @@ func (c fakeCode) Abn() string {
 		panic(err)
 	}
 
-	var sum int = 0
+	var sum int
 	for i, d := range acn {
 		n, err := strconv.Atoi(string(d))
 		if err != nil {

commerce.go

@@ -26,7 +26,7 @@ func (c fakeCommerce) Department() string {
 	n := RandomInt(1, 3)
 
 	deps := make([]string, n)
-	for i, _ := range deps {
+	for i := range deps {
 		d := Fetch("commerce.department")
 		for includesString(deps, d) {
 			d = Fetch("commerce.department")
@@ -41,9 +41,8 @@ func (c fakeCommerce) Department() string {
 			deps[len(deps)-1],
 		}, sep)
 		return res
-	} else {
-		return deps[0]
 	}
+	return deps[0]
 }
 
 func (c fakeCommerce) ProductName() string {

faker.go

@@ -1,5 +1,5 @@
 /*
-Faker is a library for generating fake data such as names, addresses, and phone numbers.
+Package faker is a library for generating fake data such as names, addresses, and phone numbers.
 
 It is a (mostly) API-compatible port of Ruby Faker gem (https://github.com/stympy/faker) to Go.
 */
@@ -27,10 +27,10 @@ const (
 )
 
 var (
-	aryDigits   []string = strings.Split(digits, "")
-	aryULetters []string = strings.Split(uLetters, "")
-	aryDLetters []string = strings.Split(dLetters, "")
-	aryLetters  []string = strings.Split(letters, "")
+	aryDigits   = strings.Split(digits, "")
+	aryULetters = strings.Split(uLetters, "")
+	aryDLetters = strings.Split(dLetters, "")
+	aryLetters  = strings.Split(letters, "")
 )
 
 // Generate locales
@@ -63,10 +63,10 @@ var (
 //go:generate go run cmd/generate.go yaml/zh-CN.yml locales/zh-cn.go
 //go:generate go run cmd/generate.go yaml/zh-TW.yml locales/zh-tw.go
 
-// Default locale.
+// Locale holds the default locale.
 var Locale = locales.En
 
-// RandonmInt returns random int in [min, max] range.
+// RandomInt returns random int in [min, max] range.
 func RandomInt(min, max int) int {
 	if max <= min {
 		// degenerate case, return min
@@ -326,6 +326,7 @@ var (
 	localRand   = &lockedReadRand{Rand: rand.New(localSource)}
 )
 
+// Seed uses the provided seed value to initialize the random source to a deterministic state.
 func Seed(seed int64) {
 	localRand.Seed(seed)
 }

finance.go

@@ -33,7 +33,7 @@ const (
 	CC_LASER              = "laser"
 )
 
-// Known credit card types.
+// CC_TYPES holds a list of known credit card types.
 var CC_TYPES = []string{
 	CC_VISA,
 	CC_MASTERCARD,

internet.go

@@ -46,7 +46,7 @@ func (i fakeInternet) SafeEmail() string {
 	return strings.Join(ss, "@")
 }
 
-var separators []string = []string{".", "_"}
+var separators = []string{".", "_"}
 var rxNonWord = regexp.MustCompile(`\W`)
 
 func sanitizeName(s string) string {