Fix typo #34
Closed
Fix typo #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was definitely meant to be "taking" not "talking". Maybe not the most poetic or even correct verb, but I will stand by it. |
|
Hmmm, "requesting" would be more clear than "taking", IMO. Because you don't have a subject, it's not clear exactly what is being taken. |
|
Could be. I want to keep my wordplay. The polite etiquette over the dinner table would be to talk slowly and listen carefully (i.e. not ask twice), but here we mean taking (downloading) data and memoising (caching). Thanks for suggestion and the fact that you felt there's a typo proves that my wordplay worked. I am closing the PR if you don't mind. |
|
I don't get the wordplay, but I'll close since it's not a typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I didn't rebuild the .md file)