Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reST documentation #34

Closed
sebkln opened this issue Nov 21, 2019 · 5 comments
Closed

Add reST documentation #34

sebkln opened this issue Nov 21, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@sebkln
Copy link
Contributor

sebkln commented Nov 21, 2019

A reStructuredText documentation on docs.typo3.org is the best way to introduce and explain the extension to users.

I will take care of this. The finished documentation will include the usual sections. The contents are taken from the current README file. I plan to extend it with a FAQ or Troubleshooting section; maybe in a later step.

@ghost
Copy link

ghost commented Nov 21, 2019

Gorgeous! Thank you :)

@ghost ghost assigned sebkln Nov 21, 2019
@sebkln
Copy link
Contributor Author

sebkln commented Nov 27, 2019

The documentation (PR #40) is built upon the example manual provided by the t3docs team. Also, some good practices were copied from EXT:news docs.

I added the contents of the README into the different sections. In order to match the other docs, I had to add or rewrite come content (see "Changes and additions").

The whole documentation was rendered successfully in a local environment.

Changes and additions

  • "Introduction" contains a new list of features.
  • "Installation" was rephrased to match EXT:news docs (but all former information is still listed there).
  • I changed some examples from <a href=""> to <button>.
  • I used the official TYPO3 data types in TypoScript Reference (e.g. boolean). The data types are linked to the TSref.
  • Some wording was changed.

Rendering on docs.typo3.org

In order to get the new documentation rendered on docs.typo3.org, the following requirements must be met:

  • Documentation must be available in 'master' branch.
  • The link to the "External Manual" on extensions.typo3.org must be removed.
  • composer.json must be up to date.
  • Set up the GitHub webhook. This allows to automatically render every change on docs.typo3.org

The new documentation adds a "Edit me on GitHub" button which allows users to quickly send PRs. If you don't want this, it can be easily removed.

reST & Sphinx How-To

You can find all necessary information about reStructuredText in the "How To document" section on docs.typo3.org. It also includes a handy Cheat Sheet.

Additional notes

"Configuration" main page only contains some text and a doctree. If you add a heading on this page, all sub pages of "Configuration" will be rendered as sub pages of this heading in the main navigation. That's just the way sphinx works. As a workaround, I added all sections as separate files.

"TypoScript reference" is rendered with definition lists. Using the old table-row markup (e.g. TSref) is no longer recommended for new docs.

Next steps

When this basic documentation is implemented, we can extend it with a new "FAQ" section inside "Configuration", e.g.:

  • How to add a new cookie group?
  • How to add a new tracking object?
  • What to consider with a Content Security Policy?

@sebkln
Copy link
Contributor Author

sebkln commented Nov 28, 2019

Cool!

When the new documentation is available on docs.typo3.org and up-to-date, I'd recommend to reduce the README.md to the general information (means: no configuration). Then you don't have to maintain two docs.

@ghost
Copy link

ghost commented Nov 28, 2019

Thank you for preparing this so thoroughly and well-thought!

I added the web hook and confirmed that https://intercept.typo3.com/admin/docs/deployments received a ping.
The "external manual" from https://extensions.typo3.org is removed.

@jonaseberle
Copy link
Member

I reduced README.md. I'll make issues for FAQ entries.
The documentation looks and reads so nice :)

@ghost ghost closed this as completed Nov 29, 2019
@ghost ghost added the enhancement New feature or request label Jan 23, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants