Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reStructuredText documentation #40

Merged
1 commit merged into from
Nov 28, 2019
Merged

Conversation

sebkln
Copy link
Contributor

@sebkln sebkln commented Nov 27, 2019

No description provided.

@sebkln sebkln mentioned this pull request Nov 27, 2019
@jonaseberle
Copy link
Member

Great. Thank you so much!

I'll pull it and we'll continue from there. I guess we need a webhook now to get it rendered and linked on extensions.typo3.org

We should add the last 2 changes from README.md, too: https://github.com/dmind-gmbh/extension-cookieman/commits/master/README.md

@ghost ghost merged commit c534d1d into dmind-gmbh:master Nov 28, 2019
@sebkln sebkln deleted the rest-documentation branch November 28, 2019 08:23
ghost pushed a commit that referenced this pull request Nov 28, 2019
Thank you @sebkln!

(cherry picked from commit c534d1d)
ghost pushed a commit that referenced this pull request Nov 28, 2019
Thank you @sebkln!

(cherry picked from commit c534d1d)
@ghost
Copy link

ghost commented Nov 28, 2019

We should add the last 2 changes from README.md, too: https://github.com/dmind-gmbh/extension-cookieman/commits/master/README.md

I've seen you took care of it already :)

I just pushed a change to the TypoScript. The \ is actually necessary:

plugin.tx_cookieman._LOCAL_LANG {
   en {
       trackingobject\.pixelphp = You can translate the name, but you do not have to.

@sebkln
Copy link
Contributor Author

sebkln commented Nov 28, 2019

Ah okay. I was able to override and set new labels without the slash, but maybe it's version dependent. I only tested this in TYPO3 v8.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants