This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Fix suffix when pretty url enabled #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Merged |
|
Thank you! Glad it's merged. Could you please release a new version so we don't need to specify the dev-master when installing? |
|
Did it, thanks you so much for support. https://github.com/dmirogin/yii2-js-urlmanager/releases/tag/1.2.2 I am going to archive this repo soon, so feel free to fork it and add needed changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a simple change to fix #2
The issue was from 2019 with no solution yet, maybe this can help anyone who still using this awesome library.
Btw, thanks for the great works.