Custom Name resolver

[RonSijm]

• Added public Func<Type, string> NameDiscriminatorResolver { get; set; } = type => type.Name; to JsonDiscriminatorSettings to allow custom Name Discriminator Resolver
• Added JsonKnownTypesSettingsManager To allow type specific config to be injected

[RonSijm]

PR resolves #30

[dmitry-bym]

Sorry for long response
Can you pls create test for the case, also update language version in project to latest
Also have found issue (not yours) with mapper if user specified DiscriminatorAttribute it will use new JsonDiscriminatorSettings to compare but need to use it from JsonKnownTypesSettingsManager.
I think it's all connected so what can be done here
So i think need to create some comparator to resolve that perfect way
but overall looks ok!

[dmitry-bym]

This is never null so it always use settings from generic manager

[RonSijm]

This will be null unless you explicitly set generic settings. For example: JsonKnownTypesSettingsManager<ClassWithDuplicateChild>.DefaultDiscriminatorSettings.NameDiscriminatorResolver = type => type.FullName;

So, first it looks for the attribute, if that is null, it will look for a specific setting for the generic type (<ClassWithDuplicateChild> in the example), if that is also null it will fall back to the default settings.

At least thats how it worked in my unittest

[RonSijm]

Can you pls create test for the case,

I did add a test for the case, it's the last file in the PR:
https://github.com/dmitry-bym/JsonKnownTypes/blob/4e99657912ef8ef8c17ec7bd8573a9b64ab2a390/tests/JsonKnownTypes.UnitTests/WithNameDiscriminatorResolverTests.cs

[dmitry-bym]

@RonSijm nope its not null cause there is default value there

public static class JsonKnownTypesSettingsManager<T>
    {
        /// <summary>
        /// Type specific default settings for discriminator
        /// </summary>
        // ReSharper disable once StaticMemberInGenericType - Justification: Intentional property should exist on a per-type base
        public static JsonDiscriminatorSettings DefaultDiscriminatorSettings { get; } = new();
    }