Upload from

[dmitry-fa]

feat: Implementation of Blob.uploadFrom(Path)

[athakor]

You need to add system test as well for testUploadFrom().

[dmitry-fa]

@athakor

You need to ddd system test as well for testUploadFrom().

I would be glad to add such test, but our credentials do not allow to run storage IT test:

io.grpc.StatusRuntimeException: PERMISSION_DENIED: Permission 'cloudkms.keyRings.setIamPolicy' denied on resource 'projects/grass-clump-479/locations/us/keyRings/gcs_test_kms_key_ring' (or it may not exist).

	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:240)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:221)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:140)
	at com.google.iam.v1.IAMPolicyGrpc$IAMPolicyBlockingStub.setIamPolicy(IAMPolicyGrpc.java:399)
	at com.google.cloud.storage.it.ITStorageTest.ensureKmsKeyRingIamPermissionsForTests(ITStorageTest.java:294)
	at com.google.cloud.storage.it.ITStorageTest.prepareKmsKeys(ITStorageTest.java:226)
	at com.google.cloud.storage.it.ITStorageTest.beforeClass(ITStorageTest.java:186)
        ...
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)

[athakor]

@athakor

You need to ddd system test as well for testUploadFrom().

I would be glad to add such test, but our credentials do not allow to run storage IT test:

io.grpc.StatusRuntimeException: PERMISSION_DENIED: Permission 'cloudkms.keyRings.setIamPolicy' denied on resource 'projects/grass-clump-479/locations/us/keyRings/gcs_test_kms_key_ring' (or it may not exist).

	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:240)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:221)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:140)
	at com.google.iam.v1.IAMPolicyGrpc$IAMPolicyBlockingStub.setIamPolicy(IAMPolicyGrpc.java:399)
	at com.google.cloud.storage.it.ITStorageTest.ensureKmsKeyRingIamPermissionsForTests(ITStorageTest.java:294)
	at com.google.cloud.storage.it.ITStorageTest.prepareKmsKeys(ITStorageTest.java:226)
	at com.google.cloud.storage.it.ITStorageTest.beforeClass(ITStorageTest.java:186)
        ...
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)

@dmitry-fa what i would suggest you, you can do one thing just create one separate test class and add test method over there for to check its functionality. If its working fine then you just copied that block of code and add it into ITStorage and dont forgot to delete that newly added test class.

[dmitry-fa]

@athakor thanks for the suggestion, I will try it out.