Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade jts from com.vividsolutions.jts to org.locationtech.jts #8

Closed
oshai opened this issue Jul 25, 2021 · 4 comments
Closed

upgrade jts from com.vividsolutions.jts to org.locationtech.jts #8

oshai opened this issue Jul 25, 2021 · 4 comments

Comments

@oshai
Copy link
Contributor

oshai commented Jul 25, 2021

Thanks for maintaining this repo! We are using it for more than a year now.
We are now migrating from legacy com.vividsolutions.jts to the new org.locationtech.jts.
Migration looks pretty straight forward: https://github.com/locationtech/jts/blob/master/MIGRATION.md
But it breaks backward compatibility.

I wanted to know if it's possible to also upgrade this project?
If you want I can create a PR.
@dmitry-zhuravlev
Copy link
Owner

Sure, lets upgrade. PR are welcome. Please create one, change readme in accordance and test if all work with the new version of JTS as expected.

oshai added a commit to oshai/jooq-postgis-spatial that referenced this issue Jul 25, 2021
@oshai
fix dmitry-zhuravlev#8 - upgrade jts
c665ac9 
Upgrade com.vividsolutions.jts to the new org.locationtech.jts
and artifact com.vividsolutions:jts:1.13 to org.locationtech.jts:jts-core:1.18.1.

Also upgrade Kotlin to latest 1.5.21.

Did some manual changes in:
JTSGeometryConverter and MCoordinateSequence to fix compilation and
warnings.
Replaced deprecated clone() with copy()
@oshai
Copy link
Contributor Author

oshai commented Aug 8, 2021

Hi, did you had a chance to take a look on PR #9 ?

@dmitry-zhuravlev
Copy link
Owner

Thanks for contribution!

@oshai
Copy link
Contributor Author

oshai commented Aug 9, 2021

Thanks for merging the PR!
Do you plan to release a new version to maven central?

@oshai oshai mentioned this issue Sep 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oshai @dmitry-zhuravlev