Remove the card feature #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryrck
force-pushed
the
remove-card-feature
branch
from
c82a51c
to
770a800
Compare
It is too big of a feature and too troubling to maintain. The "new way" is to just use the card as a regular bank account. And to pay a card is to transfer money to that account. This commit deprecates the field chargeable_type. Whenever we remove it we have to rename chargeable_id to account_id and remove the polymorphic relation. I am keeping those fields and the table cards just in case someone wants to rollback this PR.
dmitryrck
force-pushed
the
remove-card-feature
branch
from
770a800
to
2188a09
Compare
7 tasks
rafaelrpbelo
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is too big of a feature and too troubling to maintain.
The "new way" is to just use the card as a regular bank account. And to pay a card is to transfer money to that account.
This PR deprecates the field
chargeable_type. Whenever we remove it we have to renamechargeable_idtoaccount_idand remove the polymorphic relation.I am keeping those fields and the table cards just in case someone wants to rollback this PR.
#41