Skip to content

Commit

Permalink
0.9.0.1:
Browse files Browse the repository at this point in the history
	logged a bug
	minor comment tweaks
  • Loading branch information
William Harold Newman committed Apr 25, 2005
1 parent 927785a commit d90c11f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
12 changes: 12 additions & 0 deletions BUGS
Expand Up @@ -2078,3 +2078,15 @@ WORKAROUND:
the class redefinition will fail when SB-PCL::REMOVE-READER-METHOD
tries to find and remove a method with an incompatible lambda list
from the unrelated generic function.

381: incautious calls to EQUAL in fasl dumping
Compiling
(frob #(#1=(a #1#)))
(frob #(#1=(b #1#)))
(frob #(#1=(a #1#)))
in sbcl-0.9.0 causes CONTROL-STACK-EXHAUSTED. My (WHN) impression
is that this follows from the use of (MAKE-HASH-TABLE :TEST 'EQUAL)
to detect sharing, in which case fixing it might require either
getting less ambitious about detecting shared list structure, or
implementing the moral equivalent of EQUAL hash tables in a
cycle-tolerant way.
6 changes: 1 addition & 5 deletions src/compiler/dump.lisp
Expand Up @@ -277,9 +277,7 @@

;;; Open a fasl file, write its header, and return a FASL-OUTPUT
;;; object for dumping to it. Some human-readable information about
;;; the source code is given by the string WHERE. If BYTE-P is true,
;;; this file will contain no native code, and is thus largely
;;; implementation independent.
;;; the source code is given by the string WHERE.
(defun open-fasl-output (name where)
(declare (type pathname name))
(let* ((stream (open name
Expand Down Expand Up @@ -512,13 +510,11 @@

;;;; number dumping

;;; Dump a ratio.
(defun dump-ratio (x file)
(sub-dump-object (numerator x) file)
(sub-dump-object (denominator x) file)
(dump-fop 'fop-ratio file))

;;; Dump an integer.
(defun dump-integer (n file)
(typecase n
((signed-byte 8)
Expand Down
2 changes: 1 addition & 1 deletion version.lisp-expr
Expand Up @@ -17,4 +17,4 @@
;;; checkins which aren't released. (And occasionally for internal
;;; versions, especially for internal versions off the main CVS
;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
"0.9.0"
"0.9.0.1"

0 comments on commit d90c11f

Please sign in to comment.