Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHC build with text >=1.2.5 #708

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix GHC build with text >=1.2.5 #708

merged 1 commit into from
Aug 22, 2022

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Aug 22, 2022

Without this patch, we have

 $ cabal build --constraint='text >=1.2.5'
src/Miso/FFI.hs:95:35: error:
    Ambiguous occurrence ‘elem’
    It could refer to
       either ‘Prelude.elem’,
              imported from ‘Prelude’ at src/Miso/FFI.hs:14:8-15
              (and originally defined in ‘Data.Foldable’)
           or ‘Miso.String.elem’,
              imported from ‘Miso.String’ at src/Miso/FFI.hs:67:1-28
              (and originally defined in ‘Data.Text’)
   |
95 |   classSet <- ((JSS.pack "class") `elem`) <$> listProps obj
   |                                   ^^^^^^

where elem was added to Data.Text in 1.2.5.0.

@dmjio dmjio merged commit 9b76dd5 into dmjio:master Aug 22, 2022
@amesgen amesgen deleted the text-1.2.5 branch August 22, 2022 21:09
@dmjio
Copy link
Owner

dmjio commented Aug 25, 2022

@amesgen thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants