Merge pull request #282 from iblis17/srand

random: rename srand! to srand

NEWS.md

@@ -1,19 +1,25 @@
 # v0.3.0 (TBD)
 
+## New API
+
+* `deepcopy` for NDArray (#273)
+
 ## API Changes
 
 * `reshape` of NDArray share the same interface with Base (#272).
     * `reshape(NDArray, dim; reverse=false)`
     * `reshape(NDArray, dim...; reverse=false)`
     * `Reshape` deprecated.
 
-  * `reshape` of SymbolicNode share the same interface with Base
-    and additional keyword argument (#279).
+* `reshape` of SymbolicNode share the same interface with Base
+  and additional keyword argument (#279).
 
     * `reshape(SymbolicNode, dim; reverse=false, name)`
     * `reshape(SymbolicNode, dim...; reverse=false, name)`
     * `Reshape` deprecated.
 
+* `srand!` deprecated, please use `srand` (#282)
+
 # v0.2.2 (2017.05.14)
 * Updated supported version of MXNet to 0.9.4.
 * Improved build-system with support for auto-detecting GPU support.

src/deprecated.jl

@@ -5,3 +5,6 @@
 # SymbolicNode reshape (#279)
 @deprecate reshape(sym::SymbolicNode; shape=()) reshape(sym, shape)
 @deprecate Reshape(sym::SymbolicNode; shape=()) reshape(sym, shape)
+
+# srand (#282)
+@deprecate srand!(seed_state::Int) srand(seed_state)

src/random.jl

@@ -22,6 +22,6 @@ function randn{N}(mean::Real, stdvar::Real, shape::NTuple{N,Int}, ctx::Context)
   randn!(mean, stdvar, out)
 end
 
-function srand!(seed_state::Int)
+function srand(seed_state::Int)
   @mxcall(:MXRandomSeed, (Cint,), seed_state)
 end

test/unittest/random.jl

@@ -8,10 +8,10 @@ function test_uniform()
 
   low = -10; high = 10
   seed = 123
-  mx.srand!(seed)
+  mx.srand(seed)
   ret1 = mx.rand(low, high, dims)
 
-  mx.srand!(seed)
+  mx.srand(seed)
   ret2 = mx.empty(dims)
   mx.rand!(low, high, ret2)
 
@@ -25,10 +25,10 @@ function test_gaussian()
 
   μ = 10; σ = 2
   seed = 456
-  mx.srand!(seed)
+  mx.srand(seed)
   ret1 = mx.randn(μ, σ, dims)
 
-  mx.srand!(seed)
+  mx.srand(seed)
   ret2 = mx.empty(dims)
   mx.randn!(μ, σ, ret2)