ndarray: type convertion of _rdiv_scalar (#358)

Ref: #353
dmlc · Dec 4, 2017 · 642b17b · 642b17b
1 parent ad57be9
commit 642b17b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/ndarray.jl b/src/ndarray.jl
@@ -680,9 +680,10 @@ end
 
 Elementwise divide a scalar by an `NDArray`. Inplace updating.
 """
-function rdiv_from!(x::Real, y::NDArray{T}) where {T}
+function rdiv_from!(x::Real, y::NDArray)
   @assert y.writable
-  _rdiv_scalar(y, scalar = convert(T, x), out = y)
+  _rdiv_scalar(y, scalar = x, out = y)
+  y
 end
 
 import Base: /

diff --git a/test/unittest/ndarray.jl b/test/unittest/ndarray.jl
@@ -417,6 +417,13 @@ function test_rdiv()
     y = 1 ./ Float32[1 2; 3 4]
     @test copy(x) ≈ y
   end
+
+  info("NDArray:rdiv::type convert")
+  let x = mx.NDArray([1, 2, 3])
+    y = 5.5 ./ x
+    @test eltype(y) == Int  # this differs from julia
+    @test copy(y) == [5, 2, 1]
+  end
 end  # function test_rdiv