ndarray: regularize fill! API (#311)

In Base, it's fill!(A, x)
dmlc · Nov 9, 2017 · 678b49e · 678b49e
1 parent 3f93ffc
commit 678b49e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -11,7 +11,7 @@
 
     * `fill(x, dims, ctx=cpu())`
     * `fill(x, dims...)`
-    * `fill!(x, arr::NDArray)`
+    * `fill!(arr::NDArray, x)`
 
 * Matrix (2D NDArray) multiplication is available now. (#TBD)
 

diff --git a/src/ndarray.jl b/src/ndarray.jl
@@ -759,11 +759,11 @@ broadcast_(::typeof(^), x::NDArray, s::Irrational) = _power_scalar(x, scalar=s)
 broadcast_(::typeof(^), s::Irrational, x::NDArray) = _rpower_scalar(x, scalar=s)
 
 """
-    fill!(x, arr::NDArray)
+    fill!(arr::NDArray, x)
 
-Create an `NDArray` filled with the value `x`, like `Base.fill`.
+Create an `NDArray` filled with the value `x`, like `Base.fill!`.
 """
-function fill!(x, arr::NDArray)
+function Base.fill!(arr::NDArray, x)
   arr[:] = x
   arr
 end

diff --git a/test/unittest/ndarray.jl b/test/unittest/ndarray.jl
@@ -706,10 +706,10 @@ function test_fill()
   end
 
   info("NDArray::fill!::arr")
-  let x = mx.fill!(42, mx.zeros(2, 3, 4))
+  let x = fill!(mx.zeros(2, 3, 4), 42)
     @test eltype(x) == Float32
     @test size(x) == (2, 3, 4)
-    @test reldiff(copy(x), fill(Float32(42), 2, 3, 4)) < thresh
+    @test copy(x) ≈ fill(Float32(42), 2, 3, 4)
   end
 end  # function test_fill