Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #307

Merged
merged 1 commit into from Nov 8, 2017
Merged

Fix deprecations #307

merged 1 commit into from Nov 8, 2017

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Nov 8, 2017

No description provided.

@iblislin
Copy link
Member Author

iblislin commented Nov 8, 2017

I take this patch from my personal fork: iblislin#1

@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #307 into master will increase coverage by 0.07%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   68.91%   68.98%   +0.07%     
==========================================
  Files          25       25              
  Lines        1901     1899       -2     
==========================================
  Hits         1310     1310              
+ Misses        591      589       -2
Impacted Files Coverage Δ
src/random.jl 100% <ø> (ø) ⬆️
src/context.jl 80% <ø> (ø) ⬆️
src/optimizers/adam.jl 100% <ø> (ø) ⬆️
src/optimizers/adadelta.jl 100% <ø> (ø) ⬆️
src/kvstore.jl 75% <ø> (ø) ⬆️
src/optimizers/sgd.jl 76.47% <ø> (ø) ⬆️
src/ndarray.jl 83.95% <ø> (ø) ⬆️
src/executor.jl 86.9% <ø> (ø) ⬆️
src/metric.jl 29.1% <ø> (ø) ⬆️
src/name.jl 92.85% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a488d7a...cb91a47. Read the comment docs.

@pluskid pluskid merged commit f839be1 into dmlc:master Nov 8, 2017
@iblislin iblislin deleted the fbot/deps branch November 9, 2017 01:21
@iblislin iblislin added this to the v0.3.0 milestone Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants